-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safer Cluster module #315
Merged
aaron-lane
merged 29 commits into
terraform-google-modules:master
from
bharathkkb:feature/gke-safe-cluster
Nov 26, 2019
Merged
Safer Cluster module #315
aaron-lane
merged 29 commits into
terraform-google-modules:master
from
bharathkkb:feature/gke-safe-cluster
Nov 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bharathkkb
commented
Nov 11, 2019
•
edited
Loading
edited
- Added commits from Initial definition of a Safer Cluster module. #272 and docs Documentation for the Safer Cluster module. #281
- Resolved comments from Initial definition of a Safer Cluster module. #272
- Added new build step, shielded vms
The PR adds a new "safer" GKE module. The module includes hardening suggestions from multiple sources.
The PR adds a new "safer" GKE module. The module includes hardening suggestions from multiple sources.
…ubernetes-engine into safer-cluster
aaron-lane
suggested changes
Nov 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bharathkkb!
The PR adds a new "safer" GKE module. The module includes hardening suggestions from multiple sources.
aaron-lane
suggested changes
Nov 15, 2019
@aaron-lane seems like it timed out at destroy sandbox-enabled-local |
aaron-lane
previously approved these changes
Nov 21, 2019
aaron-lane
suggested changes
Nov 22, 2019
aaron-lane
approved these changes
Nov 26, 2019
aaron-lane
pushed a commit
that referenced
this pull request
Nov 26, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…re/gke-safe-cluster Safer Cluster module
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.